[Libreoffice] [REVIEWED] [PUSHED] Re: identical text for different (but close) locale at scp2/source/ooo

[Andras Timar]

Hi Kaplan,

2011/11/25 Lior Kaplan <kaplanlior at gmail.com>:
> On Thu, Nov 24, 2011 at 8:28 PM, Andras Timar <timar74 at gmail.com> wrote:
>>
>> Hi Kaplan,
>>
>> 2011/11/24 Lior Kaplan <kaplanlior at gmail.com>:
>> > On Thu, Nov 24, 2011 at 1:14 PM, Lior Kaplan <kaplanlior at gmail.com>
>> > wrote:
>> >>
>> >>
>> >> On Thu, Nov 24, 2011 at 1:05 PM, Andras Timar <timar74 at gmail.com>
>> >> wrote:
>> >>>
>> >>> Hi Kaplan,
>> >>>
>> >>> 2011/11/24 Lior Kaplan <kaplanlior at gmail.com>:
>> >>> > Hi,
>> >>> >
>> >>> > While translating some scp2 strings for 3.5 I notice duplicate
>> >>> > strings
>> >>> > which
>> >>> > looks weird (e.g. "Installs the Tamil user interface").
>> >>> >
>> >>> > I checked the sources and notice this is because we have two locales
>> >>> > for
>> >>> > Tamil:
>> >>> >
>> >>> > [STR_NAME_MODULE_LANGPACK_TA]
>> >>> > en-US = "Tamil"
>> >>> >
>> >>> > [STR_DESC_MODULE_LANGPACK_TA]
>> >>> > en-US = "Installs the Tamil user interface"
>> >>> >
>> >>> > [STR_NAME_MODULE_LANGPACK_TA_IN]
>> >>> > en-US = "Tamil"
>> >>> >
>> >>> > [STR_DESC_MODULE_LANGPACK_TA_IN]
>> >>> > en-US = "Installs the Tamil user interface"
>> >>> >
>> >>> > Do we really support two locales or this is a mistake? If we do
>> >>> > support
>> >>> > two
>> >>> > locales, the users should have a way to differentiate between the
>> >>> > two.
>> >>> >
>> >>>
>> >>> We don't support ta_IN, only ta. In fact those lines could be removed
>> >>> from scp2 (there are more to clean up I suppose).
>> >>> For supported UI locales see
>> >>> http://opengrok.libreoffice.org/xref/core/solenv/inc/langlist.mk
>> >>>
>> >>
>> >> Good to know. I'll do the clean up and send a patch...
>> >>
>> >
>> > Attaching two patches to clean the help and language pack translation
>> > strings. Also a small clean up patch for the langlist.mk file to have it
>> > sorted.
>> >
>> > Dictionary list is verified and is updated (no changes needed).
>> >
>>
>> Please push 0001 and 0003. In 0002 you were a bit greedy in deleting
>> stuff. :) Save at least qtz. I would save all languages in helppack
>> file which have an UI pack. So I don't have to remember to re-add them
>> and translators don't have to re-translate them when a language team
>> decides to translate the help, too.
>
> Fair enough. Attaching an updated patch instead of #0002... This time
> removing only languages without a translation, not without a help
> translation.
>
> qtz saved... ooops.
>
> Kaplan
>

Thanks for this cleanup. I saw that you pushed it, well done.

Andras