Reverts notification?

Michael Stahl mstahl at redhat.com
Wed Sep 24 04:38:14 PDT 2014


On 17/09/14 14:07, Jan Holesovsky wrote:
> Eike Rathke píše v St 17. 09. 2014 v 12:50 +0200:
> 
>> Also, if bug IDs are present in the revert summary, shouldn't the
>> corresponding bugs be set to REOPENED if they were already resolved or
>> closed?
> 
> I'd prefer not to do it, similarly as we don't close the bugs
> automagically when the commit has the bug id.
> 
> Sometimes there are partial reverts, sometimes there are 'Related'
> commits that can be not crucial for the bug itself.

even better, sometimes the actual fix is reverted and some other commit
actually fixed the bug already in a "better" way :)  the revert's commit
message should indicate this of course.

> The comment will go to the bug, so I'd prefer to leave the decision
> whether to re-open or not up to the QA guys, probably?

yes that's enough.




More information about the LibreOffice mailing list