Mesa (master): i965: Drop strict conformance fallback for GL_LINE_SMOOTH.

Eric Anholt anholt at kemper.freedesktop.org
Sun Jun 5 18:24:28 UTC 2011


Module: Mesa
Branch: master
Commit: d313346db6b70d27ed985e27df4fbd44f376efa0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d313346db6b70d27ed985e27df4fbd44f376efa0

Author: Eric Anholt <eric at anholt.net>
Date:   Wed May 25 12:54:49 2011 -0700

i965: Drop strict conformance fallback for GL_LINE_SMOOTH.

We do have hardware antialised lines.  If we care, we should actually
fix them to be conformant (or as close as possible) instead of using
this knob to fool testcases using swrast.

For some interesting reading on the state of GL_*_SMOOTH across
several drivers, see:
http://homepage.mac.com/arekkusu/bugs/invariance/HWAA.html

---

 src/mesa/drivers/dri/i965/brw_draw.c |    9 ---------
 1 files changed, 0 insertions(+), 9 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c
index 44d3e1b..b2e89ba 100644
--- a/src/mesa/drivers/dri/i965/brw_draw.c
+++ b/src/mesa/drivers/dri/i965/brw_draw.c
@@ -283,15 +283,6 @@ static GLboolean check_fallbacks( struct brw_context *brw,
    if (brw->intel.conformance_mode == 0)
       return GL_FALSE;
 
-   /* BRW hardware will do AA lines, but they are non-conformant it
-    * seems.  TBD whether we keep this fallback:
-    */
-   if (ctx->Line.SmoothFlag) {
-      for (i = 0; i < nr_prims; i++)
-	 if (reduced_prim[prim[i].mode] == GL_LINES) 
-	    return GL_TRUE;
-   }
-
    /* Stipple -- these fallbacks could be resolved with a little
     * bit of work?
     */




More information about the mesa-commit mailing list