Mesa (master): st/mesa: fix renderbuffer validation bug

Brian Paul brianp at kemper.freedesktop.org
Fri Aug 10 17:50:47 UTC 2012


Module: Mesa
Branch: master
Commit: cf77c29e6015d177c046adee3c48589cc9fb5015
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cf77c29e6015d177c046adee3c48589cc9fb5015

Author: Brian Paul <brianp at vmware.com>
Date:   Fri Aug 10 09:57:05 2012 -0600

st/mesa: fix renderbuffer validation bug

After we attach a new renderbuffer in this function we need to make
sure Mesa's update_framebuffer() gets called.

Fixes crash in WebGL conformance/textures/texture-attachment-formats.html,
but the test still fails for other reasons.

Fixes http://bugs.freedesktop.org/show_bug.cgi?id=53316

Note: This is a candidate for the 8.0 branch.

Reviewed-by: José Fonseca <jfonseca at vmware.com>

---

 src/mesa/state_tracker/st_cb_fbo.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c
index 7eef5c6..40e3677 100644
--- a/src/mesa/state_tracker/st_cb_fbo.c
+++ b/src/mesa/state_tracker/st_cb_fbo.c
@@ -458,6 +458,12 @@ st_render_texture(struct gl_context *ctx,
     * passed to the pipe as a (color/depth) render target.
     */
    st_invalidate_state(ctx, _NEW_BUFFERS);
+
+
+   /* Need to trigger a call to update_framebuffer() since we just
+    * attached a new renderbuffer.
+    */
+   ctx->NewState |= _NEW_BUFFERS;
 }
 
 




More information about the mesa-commit mailing list