Mesa (master): i965: Add a note about a bug from the no-recompile-on-sampler-updates change.
Eric Anholt
anholt at kemper.freedesktop.org
Fri Dec 28 19:03:48 UTC 2012
Module: Mesa
Branch: master
Commit: 50a88e2f44133759ed38ef5661da61ed394e80cf
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=50a88e2f44133759ed38ef5661da61ed394e80cf
Author: Eric Anholt <eric at anholt.net>
Date: Tue Nov 20 14:28:48 2012 -0800
i965: Add a note about a bug from the no-recompile-on-sampler-updates change.
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
---
src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
index 8967a6c..4bde6c7 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
@@ -1295,6 +1295,10 @@ fs_visitor::visit(ir_texture *ir)
fs_inst *inst = NULL;
int sampler = _mesa_get_sampler_uniform_value(ir->sampler, prog, &fp->Base);
+ /* FINISHME: We're failing to recompile our programs when the sampler is
+ * updated. This only matters for the texture rectangle scale parameters
+ * (pre-gen6, or gen6+ with GL_CLAMP).
+ */
int texunit = fp->Base.SamplerUnits[sampler];
/* Should be lowered by do_lower_texture_projection */
More information about the mesa-commit
mailing list