Mesa (master): glsl: Remove unused include from glsl_symbol_table.h

Matt Turner mattst88 at kemper.freedesktop.org
Tue Jun 10 20:08:08 UTC 2014


Module: Mesa
Branch: master
Commit: 4f5445a45d3ed02e00a061b10c943c0b079c6020
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f5445a45d3ed02e00a061b10c943c0b079c6020

Author: Thomas Helland <thomashelland90 at gmail.com>
Date:   Tue Jun 10 00:57:37 2014 +0200

glsl: Remove unused include from glsl_symbol_table.h

Only function-defs use glsl_type so forward declare instead.
Compile-tested on my Ivy-bridge system.

IWYU also suggests removing #include <new>, and this compiles fine.
I'm not familiar enough with memory management in C/C++ that I feel
comfortable removing this. Insights would be appreciated.

Reviewed-by: Tom Stellard <thomas.stellard at amd.com>
Reviewed-by: Matt Turner <mattst88 at gmail.com>
Signed-off-by: Thomas Helland <thomashelland90 at gmail.com>

---

 src/glsl/glsl_symbol_table.h |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/glsl/glsl_symbol_table.h b/src/glsl/glsl_symbol_table.h
index f323fc3..39b84e4 100644
--- a/src/glsl/glsl_symbol_table.h
+++ b/src/glsl/glsl_symbol_table.h
@@ -32,9 +32,9 @@ extern "C" {
 #include "program/symbol_table.h"
 }
 #include "ir.h"
-#include "glsl_types.h"
 
 class symbol_table_entry;
+class glsl_type;
 
 /**
  * Facade class for _mesa_symbol_table




More information about the mesa-commit mailing list