[Mesa-dev] [PATCH] intel: Enable creating FBO with luminance texture as render target

Anuj Phogat anuj.phogat at gmail.com
Thu Mar 15 19:51:37 PDT 2012


On Thu, Mar 15, 2012 at 3:11 PM, Eric Anholt <eric at anholt.net> wrote:

> On Fri,  9 Mar 2012 14:47:32 -0800, Anuj Phogat <anuj.phogat at gmail.com>
> wrote:
> > Currently intel driver doesn't allow to create a FBO with luminace
> texture
> > as render target. Piglit test getteximage-luminance skips a sub test due
> to
> > this restriction. Test passes as expected after applying this patch.
> >
> > Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
> > ---
> >  src/mesa/drivers/dri/i965/brw_wm_surface_state.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > index a3de2e3..7520219 100644
> > --- a/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > +++ b/src/mesa/drivers/dri/i965/brw_wm_surface_state.c
> > @@ -541,6 +541,7 @@ brw_init_surface_formats(struct brw_context *brw)
> >      */
> >     brw->format_supported_as_render_target[MESA_FORMAT_S8_Z24] = true;
> >     brw->format_supported_as_render_target[MESA_FORMAT_X8_Z24] = true;
> > +   brw->format_supported_as_render_target[MESA_FORMAT_L8] = true;
> >     brw->format_supported_as_render_target[MESA_FORMAT_S8] = true;
> >     brw->format_supported_as_render_target[MESA_FORMAT_Z16] = true;
> >     brw->format_supported_as_render_target[MESA_FORMAT_Z32_FLOAT] = true;
>
> I would not have expected this to work.  Did you do a full piglit run?
>
Thanks for reminding. I missed the full piglit run on this patch. Just
tested with getteximage-luminance.
Now i did the full run and seeing many failures.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20120315/496cd2f8/attachment.htm>


More information about the mesa-dev mailing list