[Mesa-dev] [PATCH 1/2] r300g: handle unsupported blend factor gracefully

Marek Olšák maraeo at gmail.com
Fri Feb 6 07:50:06 PST 2015


Michel is right. Nine shouldn't use the blend factors if the driver
doesn't support them.

The removal of the "XXX" comment is okay and can be moved to patch 2.

Marek

On Fri, Feb 6, 2015 at 3:46 AM, Michel Dänzer <michel at daenzer.net> wrote:
> On 06.02.2015 09:14, David Heidelberg wrote:
>> these days all (r600+,nv50+) modern HW support
>> PIPE_CAP_MAX_DUAL_SOURCE_RENDER_TARGETS Konsole output which r300 don't.
>>
>> Instead of adding another expensive checks to Nine,
>
> Why would that be expensive? It only needs to be done once per pipe_screen.
>
>> this is way to simply avoid it and do not cause assertion at no cost.
>
> Sounds like a rather bad solution to me.
>
>
> --
> Earthling Michel Dänzer               |               http://www.amd.com
> Libre software enthusiast             |             Mesa and X developer
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list