[Mesa-dev] [PATCH 1/2] r300g: handle unsupported blend factor gracefully

Roland Scheidegger sroland at vmware.com
Fri Feb 6 11:53:21 PST 2015


FWIW I'm wondering why you'd actually need them in a d3d9 state tracker,
as this is a feature first seen with d3d10. Unless you'd want to handle
d3d10 of course, but in this case there's probably not much hope for any
of the d3d9 capable hw drivers for lots of reasons...

Roland

Am 06.02.2015 um 16:50 schrieb Marek Olšák:
> Michel is right. Nine shouldn't use the blend factors if the driver
> doesn't support them.
> 
> The removal of the "XXX" comment is okay and can be moved to patch 2.
> 
> Marek
> 
> On Fri, Feb 6, 2015 at 3:46 AM, Michel Dänzer <michel at daenzer.net> wrote:
>> On 06.02.2015 09:14, David Heidelberg wrote:
>>> these days all (r600+,nv50+) modern HW support
>>> PIPE_CAP_MAX_DUAL_SOURCE_RENDER_TARGETS Konsole output which r300 don't.
>>>
>>> Instead of adding another expensive checks to Nine,
>>
>> Why would that be expensive? It only needs to be done once per pipe_screen.
>>
>>> this is way to simply avoid it and do not cause assertion at no cost.
>>
>> Sounds like a rather bad solution to me.
>>
>>
>> --
>> Earthling Michel Dänzer               |               https://urldefense.proofpoint.com/v2/url?u=http-3A__www.amd.com&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Vjtt0vs_iqoI31UfJxBl7yv9I2FeiaeAYgMTLKRBc_I&m=Tq6CZwbR4287ULTg72PV0zXNhUmCOKXoMdDiCCXKV1c&s=ZcJdlbHx3QlWcDNEVkx98qWZPPqDVseo8mXJCsQ9s7s&e= 
>> Libre software enthusiast             |             Mesa and X developer
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Vjtt0vs_iqoI31UfJxBl7yv9I2FeiaeAYgMTLKRBc_I&m=Tq6CZwbR4287ULTg72PV0zXNhUmCOKXoMdDiCCXKV1c&s=8Oe9wL5nMjcjJ0uHE8wsIhfPd7qxXrNS9PqF8dBKUho&e= 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.freedesktop.org_mailman_listinfo_mesa-2Ddev&d=AwIGaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=Vjtt0vs_iqoI31UfJxBl7yv9I2FeiaeAYgMTLKRBc_I&m=Tq6CZwbR4287ULTg72PV0zXNhUmCOKXoMdDiCCXKV1c&s=8Oe9wL5nMjcjJ0uHE8wsIhfPd7qxXrNS9PqF8dBKUho&e= 
> 



More information about the mesa-dev mailing list