[Mesa-dev] [Bug 88907] [PNV Bisected]Ogles2conform ES2-CTS.gtf.GL2ExtensionTests.texture_float.texture_float segfault

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=88907

--- Comment #3 from Ian Romanick <idr at freedesktop.org> ---
Comment on attachment 113390
  --> https://bugs.freedesktop.org/attachment.cgi?id=113390
patch to fix the issue

Review of attachment 113390:
-----------------------------------------------------------------

I think the problem is that adjust_for_oes_float_texture is called even when
internalFormat is not GL_FLOAT, GL_HALF_FLOAT_OES, or GL_HALF_FLOAT.

It seems like this would be better:

      if (_mesa_is_gles(ctx) && format == internalFormat) {
         if (type == GL_FLOAT) {
            texObj->_IsFloat = GL_TRUE;
            internalFormat = adjust_for_oes_float_texture(format, type);
         } else if (type == GL_HALF_FLOAT_OES || type == GL_HALF_FLOAT) {
            texObj->_IsHalfFloat = GL_TRUE;
            internalFormat = adjust_for_oes_float_texture(format, type);
         }
      }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150212/609b0104/attachment.html>