[Mesa-dev] [PATCH] i965/vec4: Override destination register writemask in sampler message send.

[Francisco Jerez]

Hi Ian,

Ian Romanick <idr at freedesktop.org> writes:

> Please tag the commit with
>
> Cc: "10.5" <mesa-stable at lists.freedesktop.org>
>

I don't think that's necessary, the commit that caused this regression
isn't part of 10.5.

> On 02/13/2015 05:03 AM, Francisco Jerez wrote:
>> This line was removed by accident in commit
>> 16b911257440afbd77a6eb762e28df62e3c19bc7 causing a regression in the
>> ES3-CTS.gtf.GL3Tests.shadow.shadow_execution_vert Khronos conformance
>> test.  It's necessary because the swizzle_result() code below expects
>> all four components of the vector to be valid.
>> 
>> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89094
>> Tested-by: Lu Hua <huax.lu at intel.com>
>> Cc: Matt Turner <mattst88 at gmail.com>
>> ---
>>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
>> index 9421786..eb69ebb 100644
>> --- a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
>> +++ b/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp
>> @@ -2613,6 +2613,7 @@ vec4_visitor::visit(ir_texture *ir)
>>        is_high_sampler(brw, sampler_reg);
>>     inst->base_mrf = 2;
>>     inst->mlen = inst->header_present + 1; /* always at least one */
>> +   inst->dst.writemask = WRITEMASK_XYZW;
>>     inst->shadow_compare = ir->shadow_comparitor != NULL;
>>  
>>     inst->src[1] = sampler_reg;
>> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150216/636ad3e3/attachment.sig>