[Mesa-dev] [PATCH] anv/cmd_buffer: Actually use the stencil dimension

[Jason Ekstrand]

On Wed, Nov 30, 2016 at 10:20 AM, Nanley Chery <nanleychery at gmail.com>
wrote:

> On Tue, Nov 29, 2016 at 05:41:58PM -0800, Jason Ekstrand wrote:
> > In an attempt to fix 3DSTATE_DEPTH_BUFFER for stencil-only cases, I
> > accidentally kept setting the SurfaceType to 2D in the stencil-only case
> > thanks to a copy+paste error.
> >
> > Cc: Nanley Chery <nanley.g.chery at intel.com>
> > ---
> >  src/intel/vulkan/genX_cmd_buffer.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Thanks for the fix! This patch is,
> Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
>

Thanks!  Pushed.  Sorry for the mess.


> >
> > diff --git a/src/intel/vulkan/genX_cmd_buffer.c
> b/src/intel/vulkan/genX_cmd_buffer.c
> > index 73f4523..f761d9a 100644
> > --- a/src/intel/vulkan/genX_cmd_buffer.c
> > +++ b/src/intel/vulkan/genX_cmd_buffer.c
> > @@ -2153,7 +2153,7 @@ cmd_buffer_emit_depth_stencil(struct
> anv_cmd_buffer *cmd_buffer)
> >         */
> >        anv_batch_emit(&cmd_buffer->batch, GENX(3DSTATE_DEPTH_BUFFER),
> db) {
> >           if (has_stencil) {
> > -            db.SurfaceType       = SURFTYPE_2D;
> > +            db.SurfaceType       =
> >                 depth_stencil_surface_type(image->stencil_surface.isl.
> dim);
> >           } else {
> >              db.SurfaceType       = SURFTYPE_2D;
> > --
> > 2.5.0.400.gff86faf
> >
> > _______________________________________________
> > mesa-dev mailing list
> > mesa-dev at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161130/47950b6a/attachment.html>