[Mesa-dev] [PATCH] mesa: make attribute binding message more useful

[Iago Toral]

On Fri, 2016-07-01 at 14:00 +1000, Timothy Arceri wrote:
> ---
>  src/mesa/main/shader_query.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/mesa/main/shader_query.cpp b/src/mesa/main/shader_query.cpp
> index b5e1a44..a2a93b1 100644
> --- a/src/mesa/main/shader_query.cpp
> +++ b/src/mesa/main/shader_query.cpp
> @@ -84,7 +84,8 @@ _mesa_BindAttribLocation(GLuint program, GLuint index,
>     }
>  
>     if (index >= ctx->Const.Program[MESA_SHADER_VERTEX].MaxAttribs) {
> -      _mesa_error(ctx, GL_INVALID_VALUE, "glBindAttribLocation(index)");
> +      _mesa_error(ctx, GL_INVALID_VALUE, "glBindAttribLocation(%u >= %u)",
> +                  index, ctx->Const.Program[MESA_SHADER_VERTEX].MaxAttribs);

Feel free to ignore this if you think it does not add anything
significant, but maybe we can make it a bit more clear by saying
something like:

"glBindAttribLocation(%u): %u exceeds the maximum number of attributes
(%u)"

Either way:
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

>        return;
>     }
>