[Mesa-dev] [Bug 98681] ir_builder_print_visitor.cpp:401:67: error: expected ')' before 'PRIx64'

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=98681

--- Comment #5 from Brian Paul <brianp at vmware.com> ---
(In reply to Roland Scheidegger from comment #4)
> (In reply to Brian Paul from comment #3)
> > Actually, this is still failing with our Jenkins build.  Hmm...
> 
> I've got some feeling this is due this being in c++ code?

Yes.  It looks like this is the first place we've compiled a .cpp file with
PRIx64 with MinGW.

My local MinGW build is picking up inttypes.h from /usr/include/inttypes.h but
on Jenkins it's picking /usr/i686-w64-mingw32/include/inttypes.h. Don't know
why.  In the later, the PRI* macros are not defined for __cplusplus.

It looks like we have to add something like
#ifndef PRIx64
#define PRIx64 "lx"
#endif

in ir_builder_print_visitor.cpp

But then I get additional warnings about the format string and argument type
not agreeing.  And defining PRIx64 to "llx" yields other warnings in my test:

pri64.cpp:17:42: warning: unknown conversion type character ‘l’ in format
[-Wformat]
pri64.cpp:17:42: warning: too many arguments for format [-Wformat-extra-args]

I think I'll just have to add the #ifndef stuff and live with the warning.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20161111/e282c903/attachment.html>