[Mesa-dev] [PATCH 000/140] RadeonSI: Initial Vega10 support

Mike Lothian mike at fireburn.co.uk
Thu Mar 30 14:02:37 UTC 2017


I get warnings with patch 058/140

/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/gfx9/gfx9_gb_reg.h:39:7:
warning: type 'union GB_ADDR_CONFIG' violates the C++ One Definition Rule
[-Wodr]
 union GB_ADDR_CONFIG {
       ^
/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/r800/si_gb_reg.h:92:3:
note: a different type is defined in another translation unit
 } GB_ADDR_CONFIG;
   ^
/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/gfx9/gfx9_gb_reg.h:74:7:
note: the first difference of corresponding definitions is field 'bitfields'
     } bitfields, bits;
       ^
/var/tmp/portage/media-libs/mesa-9999/work/mesa-9999/src/amd/addrlib/inc/chip/r800/si_gb_reg.h:90:25:
note: a field with different name is defined in another translation unit
      unsigned int val : 32;

On Tue, 21 Mar 2017 at 19:19 Marek Olšák <maraeo at gmail.com> wrote:

> On Tue, Mar 21, 2017 at 8:07 PM, Grazvydas Ignotas <notasas at gmail.com>
> wrote:
> > This doesn't build for me:
> >
> > make[4]: Entering directory
> > '/home/notaz/src/radeon/mesa/src/gallium/winsys/amdgpu/drm'
> >   CC       amdgpu_bo.lo
> > amdgpu_bo.c: In function ‘amdgpu_buffer_get_metadata’:
> > amdgpu_bo.c:615:53: error: ‘AMDGPU_TILING_SWIZZLE_MODE_SHIFT’
> > undeclared (first use in this function)
> >        md->u.gfx9.swizzle_mode = AMDGPU_TILING_GET(tiling_flags,
> SWIZZLE_MODE);
> >                                                      ^
> > I guess it needs newer amdgpu_drm.h from the kernel, but that will
> > take a while to arrive, so maybe add some compat macros if you plan to
> > merge this soon?
>
> Yeah, I still have to find a way to deal with that bit.
>
> Marek
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20170330/240a050b/attachment.html>


More information about the mesa-dev mailing list