[Mesa-dev] [PATCH v5 0/4] Disable glthread if libX11 isn't thread-safe

Dieter Nützel Dieter at nuetzel-hh.de
Mon May 29 14:45:52 UTC 2017


Hi Gregory,

there isn't currently a copy of this on Mesa-Patchwork.
Can you please send one over there?

And maybe an updated version of:
[PATCH v5 0/3] asynchronous pbo transfer with glthread

Would be awesome.

Dieter

Am 29.05.2017 13:18, schrieb Gregory Hainaut:
> Hello Mesa developers,
> 
> Following the discussion from
> https://lists.freedesktop.org/archives/mesa-dev/2017-April/153137.html
> 
> A check was added to ensure that X11 display can be locked. It should 
> be enough
> to ensure thread safety between X11 and glthread.
> 
> I also did the check on DRI3 as I'm not 100% sure that it is really 
> thread safe.
> 
> ------------------------------------
> 
> v2: based on Nicolai/Matt reviews
> Add a check on DRI extension version
> Use C comments :)
> 
> v3: based on Emil reviews
> Split the initial first patch into 3 sub patches dri extension / glx / 
> egl
> Improve error message
> Improve code readability
> Just include libX11 on EGL protected by ifdef
> 
> v4: based on Eric feedback, I marked DRI3 as always thread safe
> 
> v5: Fix the null pointer check on patch 4. I added Daniel comment on
> patch 3 but I'm not sure I got it right.
> 
> Thanks you for all the review comments.
> 
> Best regards,
> 
> 
> Gregory Hainaut (4):
>   dri: Extend __DRIbackgroundCallableExtensionRec to include a callback
>     that checks for thread safety
>   glx: implement __DRIbackgroundCallableExtension.isThreadSafe
>   egl: implement __DRIbackgroundCallableExtension.isThreadSafe
>   glthread/gallium: require safe_glthread to start glthread
> 
>  include/GL/internal/dri_interface.h          | 13 +++++++++++
>  src/egl/drivers/dri2/egl_dri2.c              | 34 
> +++++++++++++++++++++++++++-
>  src/gallium/state_trackers/dri/dri_context.c | 21 +++++++++++++----
>  src/glx/dri2_glx.c                           | 15 +++++++++++-
>  src/glx/dri3_glx.c                           | 12 +++++++++-
>  5 files changed, 88 insertions(+), 7 deletions(-)


More information about the mesa-dev mailing list