[Mesa-dev] [PATCH 06/14] intel/compiler: remove old 16-bit shuffle/unshuffle functions

[Jason Ekstrand]

Yes, please. :-)  Patches 3-6 are,

Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>

On Sat, Jun 9, 2018 at 4:13 AM, Jose Maria Casanova Crespo <
jmcasanova at igalia.com> wrote:

> ---
>  src/intel/compiler/brw_fs.h       | 11 ------
>  src/intel/compiler/brw_fs_nir.cpp | 62 -------------------------------
>  2 files changed, 73 deletions(-)
>
> diff --git a/src/intel/compiler/brw_fs.h b/src/intel/compiler/brw_fs.h
> index 779170ecc95..d72164ae0b6 100644
> --- a/src/intel/compiler/brw_fs.h
> +++ b/src/intel/compiler/brw_fs.h
> @@ -508,17 +508,6 @@ fs_reg shuffle_64bit_data_for_32bit_write(const
> brw::fs_builder &bld,
>                                            const fs_reg &src,
>                                            uint32_t components);
>
> -void shuffle_32bit_load_result_to_16bit_data(const brw::fs_builder &bld,
> -                                             const fs_reg &dst,
> -                                             const fs_reg &src,
> -                                             uint32_t first_component,
> -                                             uint32_t components);
> -
> -void shuffle_16bit_data_for_32bit_write(const brw::fs_builder &bld,
> -                                        const fs_reg &dst,
> -                                        const fs_reg &src,
> -                                        uint32_t components);
> -
>  void shuffle_from_32bit_read(const brw::fs_builder &bld,
>                               const fs_reg &dst,
>                               const fs_reg &src,
> diff --git a/src/intel/compiler/brw_fs_nir.cpp
> b/src/intel/compiler/brw_fs_nir.cpp
> index a54935f7049..7e738ade82e 100644
> --- a/src/intel/compiler/brw_fs_nir.cpp
> +++ b/src/intel/compiler/brw_fs_nir.cpp
> @@ -5263,40 +5263,6 @@ shuffle_32bit_load_result_to_64bit_data(const
> fs_builder &bld,
>     }
>  }
>
> -void
> -shuffle_32bit_load_result_to_16bit_data(const fs_builder &bld,
> -                                        const fs_reg &dst,
> -                                        const fs_reg &src,
> -                                        uint32_t first_component,
> -                                        uint32_t components)
> -{
> -   assert(type_sz(src.type) == 4);
> -   assert(type_sz(dst.type) == 2);
> -
> -   /* A temporary is used to un-shuffle the 32-bit data of each component
> in
> -    * into a valid 16-bit vector. We can't write directly to dst because
> it
> -    * can be the same register as src and in that case the first MOV in
> the
> -    * loop below would overwrite the data read in the second MOV.
> -    */
> -   fs_reg tmp = retype(bld.vgrf(src.type), dst.type);
> -
> -   for (unsigned i = 0; i < components; i++) {
> -      const fs_reg component_i =
> -         subscript(offset(src, bld, (first_component + i) / 2), dst.type,
> -                   (first_component + i) % 2);
> -
> -      bld.MOV(offset(tmp, bld, i % 2), component_i);
> -
> -      if (i % 2) {
> -         bld.MOV(offset(dst, bld, i -1), offset(tmp, bld, 0));
> -         bld.MOV(offset(dst, bld, i), offset(tmp, bld, 1));
> -      }
> -   }
> -   if (components % 2) {
> -      bld.MOV(offset(dst, bld, components - 1), tmp);
> -   }
> -}
> -
>  /**
>   * This helper does the inverse operation of
>   * SHUFFLE_32BIT_LOAD_RESULT_TO_64BIT_DATA.
> @@ -5329,34 +5295,6 @@ shuffle_64bit_data_for_32bit_write(const
> fs_builder &bld,
>     return dst;
>  }
>
> -void
> -shuffle_16bit_data_for_32bit_write(const fs_builder &bld,
> -                                   const fs_reg &dst,
> -                                   const fs_reg &src,
> -                                   uint32_t components)
> -{
> -   assert(type_sz(src.type) == 2);
> -   assert(type_sz(dst.type) == 4);
> -
> -   /* A temporary is used to shuffle the 16-bit data of each component in
> the
> -    * 32-bit data vector. We can't write directly to dst because it can
> be the
> -    * same register as src and in that case the first MOV in the loop
> below
> -    * would overwrite the data read in the second MOV.
> -    */
> -   fs_reg tmp = bld.vgrf(dst.type);
> -
> -   for (unsigned i = 0; i < components; i++) {
> -      const fs_reg component_i = offset(src, bld, i);
> -      bld.MOV(subscript(tmp, src.type, i % 2), component_i);
> -      if (i % 2) {
> -         bld.MOV(offset(dst, bld, i / 2), tmp);
> -      }
> -   }
> -   if (components % 2) {
> -      bld.MOV(offset(dst, bld, components / 2), tmp);
> -   }
> -}
> -
>  /*
>   * This helper takes a source register and un/shuffles it into the
> destination
>   * register.
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/mesa-dev/attachments/20180613/23e32f2f/attachment.html>