[PATCH 1/4] build: remove incomplete support for code coverage

Aleksander Morgado aleksander at aleksander.es
Sun Jan 11 10:44:43 PST 2015


On Sun, Jan 11, 2015 at 3:07 PM, Jakub Sitnicki <jsitnicki at gmail.com> wrote:
> Looks like make targets for generating code coverage reports with LCOV
> were copied from GLib but corresponding changes to configure.ac were not
> made. Clean it up.

gtester.make was imported just to handle the unit testing support, so
yeah, code coverage was totally ignored.

Pushed to git master, thanks!

> ---
>  gtester.make | 20 --------------------
>  1 file changed, 20 deletions(-)
>
> diff --git a/gtester.make b/gtester.make
> index 40348dc..f9cb816 100644
> --- a/gtester.make
> +++ b/gtester.make
> @@ -67,25 +67,5 @@ test-report perf-report full-report: ${TEST_PROGS}
>           }
>  .PHONY: test test-report perf-report full-report test-nonrecursive
>
> -.PHONY: lcov genlcov lcov-clean
> -# use recursive makes in order to ignore errors during check
> -lcov:
> -       -$(MAKE) $(AM_MAKEFLAGS) -k check
> -       $(MAKE) $(AM_MAKEFLAGS) genlcov
> -
> -# we have to massage the lcov.info file slightly to hide the effect of libtool
> -# placing the objects files in the .libs/ directory separate from the *.c
> -# we also have to delete tests/.libs/libmoduletestplugin_*.gcda
> -genlcov:
> -       rm -f $(top_builddir)/tests/.libs/libmoduletestplugin_*.gcda
> -       $(LTP) --directory $(top_builddir) --capture --output-file glib-lcov.info --test-name GLIB_PERF --no-checksum --compat-libtool
> -       LANG=C $(LTP_GENHTML) --prefix $(top_builddir) --output-directory glib-lcov --title "GLib Code Coverage" --legend --show-details glib-lcov.info
> -       @echo "file://$(abs_top_builddir)/glib-lcov/index.html"
> -
> -lcov-clean:
> -       -$(LTP) --directory $(top_builddir) -z
> -       -rm -rf glib-lcov.info glib-lcov
> -       -find -name '*.gcda' -print | xargs rm
> -
>  # run tests in cwd as part of make check
>  check-local: test-nonrecursive
> --
> 1.9.3
>



-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list