[Nouveau] Kernel patch: validate nouveau_channel_get id argument

Francisco Jerez currojerez at riseup.net
Sun Dec 26 03:00:46 PST 2010


Michel Hermier <michel.hermier at gmail.com> writes:

> For my culture, why did you not changed the type to uint32_t like in
> my original patch ?
As I told you before, those changes went over the 80 column limit so I
just left them out.  I hope you don't mind, the modified patch should do
the same thing as the original one for all practical purposes.

> Also looking at include/drm/nouveau_drm.h, I see some inconsistant
> type for channel in ioctls structures ?
>
Right, explicitly sized integers are usually the preferred choice in the
IOCTL API.

> 2010/12/25 Francisco Jerez <currojerez at riseup.net>:
>> Michel Hermier <michel.hermier at gmail.com> writes:
>>
>>> Second try ^^ I'm not used at all at preparing patch for kernel
>>
>> Thanks. I've pushed it with a couple of minor fixes.
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/nouveau/attachments/20101226/b8f89ee4/attachment.pgp>


More information about the Nouveau mailing list