[Nouveau] Kernel patch: validate nouveau_channel_get id argument

Michel Hermier michel.hermier at gmail.com
Sun Dec 26 03:07:57 PST 2010


2010/12/26 Francisco Jerez <currojerez at riseup.net>:
> Michel Hermier <michel.hermier at gmail.com> writes:
>
>> For my culture, why did you not changed the type to uint32_t like in
>> my original patch ?
> As I told you before, those changes went over the 80 column limit so I
> just left them out.  I hope you don't mind, the modified patch should do
> the same thing as the original one for all practical purposes.

I don't really care since it fix the issue, but for long term I think we should
change theses to uint32_t

>> Also looking at include/drm/nouveau_drm.h, I see some inconsistant
>> type for channel in ioctls structures ?
>>
> Right, explicitly sized integers are usually the preferred choice in the
> IOCTL API.

Changing them to uint32_t would require an PATCHLEVEL++ even if the
valid values where uint32_t ??


More information about the Nouveau mailing list