[Openicc] cups-filters

[Joseph Simon]

Hello Till,

Of course - I will aim for lmcs2, but will do my best to make cups-filters
build on lcms1 as well.

As of now, rastertopdf should be able to embed any ICC profile, as long as
the profile's data color space matches the color space in the header of the
PWG raster (cmsSigRgbData <=> CUPS_CSPACE_RGB).

For testing purposes, please use the "profile=" as a CUPS option, and then
specify a local ICC profile path as its value.

Joe


On Sat, Aug 9, 2014 at 11:10 AM, Till Kamppeter <till.kamppeter at gmail.com>
wrote:

> That's it. It works now. Thank you very much.
>
> In general you should concentrate your developemnt on working with
> lcms2, as lcms1 is not maintained upstream any more and therefore
> obsolete. So it must work with lcms2 and support for lcms1 is a plus.
>
>    Till
>
>
> On 08/09/2014 06:54 PM, Joseph Simon wrote:
> > Dear Till,
> >
> > Please rebuild using rev. 7255 of cups-filters. This should be fixed.
> >
> > Joe
> >
> >
> > On Fri, Aug 8, 2014 at 11:41 PM, Till Kamppeter
> > <till.kamppeter at gmail.com <mailto:till.kamppeter at gmail.com>> wrote:
> >
> >     Sorry, still gives error, probably 32/64-bit issues. I am using
> 64-bit.
> >
> >        Till
> >
> >     ----------
> >
> >       CXX      rastertopdf-rastertopdf.o
> >     filter/rastertopdf.cpp:86:25: warning: anonymous variadic macros were
> >     introduced in C99 [-Wvariadic-macros]
> >      #define dprintf(format, ...) fprintf(stderr, "DEBUG2: (" PROGRAM ")
> "
> >     format, __VA_ARGS__)
> >                              ^
> >     filter/rastertopdf.cpp:88:25: warning: anonymous variadic macros were
> >     introduced in C99 [-Wvariadic-macros]
> >      #define iprintf(format, ...) fprintf(stderr, "INFO: (" PROGRAM ") "
> >     format, __VA_ARGS__)
> >                              ^
> >     filter/rastertopdf.cpp: In function ‘QPDFObjectHandle
> >     embedIccProfile(QPDF&)’:
> >     filter/rastertopdf.cpp:212:56: error: cannot convert ‘size_t* {aka
> long
> >     unsigned int*}’ to ‘cmsUInt32Number* {aka unsigned int*}’ for
> argument
> >     ‘3’ to ‘cmsBool cmsSaveProfileToMem(cmsHPROFILE, void*,
> >     cmsUInt32Number*)’
> >        cmsSaveProfileToMem(colorProfile, NULL, &profile_size);
> >                                                             ^
> >     filter/rastertopdf.cpp:213:34: warning: ISO C++ forbids variable
> length
> >     array ‘buff’ [-Wvla]
> >        unsigned char buff[profile_size];
> >                                       ^
> >     filter/rastertopdf.cpp:214:56: error: cannot convert ‘size_t* {aka
> long
> >     unsigned int*}’ to ‘cmsUInt32Number* {aka unsigned int*}’ for
> argument
> >     ‘3’ to ‘cmsBool cmsSaveProfileToMem(cmsHPROFILE, void*,
> >     cmsUInt32Number*)’
> >        cmsSaveProfileToMem(colorProfile, buff, &profile_size);
> >                                                             ^
> >     filter/rastertopdf.cpp: In function ‘int
> convert_raster(cups_raster_t*,
> >     unsigned int, unsigned int, int, int, pdf_info*)’:
> >     filter/rastertopdf.cpp:510:12: warning: unused variable ‘pixels’
> >     [-Wunused-variable]
> >          int i, pixels;
> >                 ^
> >     filter/rastertopdf.cpp: In function ‘int main(int, char**)’:
> >     filter/rastertopdf.cpp:697:18: warning: unused variable ‘val’
> >     [-Wunused-variable]
> >          const char  *val;  /* Option value */
> >                       ^
> >     filter/rastertopdf.cpp: At global scope:
> >     filter/rastertopdf.cpp:570:21: warning: ‘unsigned int
> >     getCMSColorSpaceType(cmsColorSpaceSignature)’ defined but not used
> >     [-Wunused-function]
> >      static unsigned int getCMSColorSpaceType(cmsColorSpaceSignature cs)
> >                          ^
> >     make[1]: *** [rastertopdf-rastertopdf.o] Error 1
> >     make[1]: Leaving directory `/home/till/printing/cups/bzr/y'
> >     make: *** [all] Error 2
> >     till at till:~/printing/cups/bzr/y$
> >
> >
> >
> >     On 08/09/2014 01:32 AM, Joseph Simon wrote:
> >     > Till,
> >     >
> >     > The lcms naming issue should be patched up in rev. 7250.
> >     >
> >     > Joe
> >     >
> >     >
> >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/openicc/attachments/20140813/1767b8a2/attachment.html>