[Piglit] [PATCH 1/2] Fix redundant static-write-varying-01.frag tests.

[Paul Berry]

On 10 November 2011 15:36, Chad Versace <chad.versace at linux.intel.com>wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> On 11/10/2011 11:38 AM, Paul Berry wrote:
> > When the static-write-varying-01.frag tests were introduced, they were
> > accidentally made the same as the corresponding
> > static-write-varying-02.frag.
> >
> > The original intent (from talking to Chad) was for one set of tests
> > verify that varyings can't be written to via direct assignment, and
> > the other set of tests to verify that varyings can't be written to via
> > passing to a function as an "out" parameter.
>
> Thanks for cleaning this up. There's a few silly mistakes in the tests.
>
> >
> > This patch updates static-write-varying-01.frag to reflect the
> > original intent.
> > ---
> >  .../storage-qualfiers/static-write-varying-01.frag |    6 +-----
> >  .../storage-qualfiers/static-write-varying-01.frag |    6 +-----
> >  .../storage-qualfiers/static-write-varying-01.frag |    6 +-----
> >  3 files changed, 3 insertions(+), 15 deletions(-)
> >
> > diff --git
> a/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag
> b/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag
> > index e5548c5..aedbc02 100644
> > ---
> a/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag
> > +++
> b/tests/spec/glsl-1.00/compiler/storage-qualfiers/static-write-varying-01.frag
> > @@ -10,10 +10,6 @@
> >
> >  varying float x;
> >
> > -void f(out float y) {
> > -    y = 0.0;
> > -}
> > -
> >  void g() {
> > -    f(x);
> > +    y = 0.0;
> >  }
>
> That should be x = 0.0.
>

Argh, oops.  Thanks for catching these.


>
> > diff --git
> a/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag
> b/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag
> > index 11b5834..48f54d0 100644
> > ---
> a/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag
> > +++
> b/tests/spec/glsl-1.10/compiler/storage-qualfiers/static-write-varying-01.frag
> > @@ -10,10 +10,6 @@
> >
> >  varying float x;
> >
> > -void f(out float y) {
> > -    y = 0.0;
> > -}
> > -
> >  void g() {
> > -    f(x);
> > +    x = 0.0;
> >  }
>
> Correct here.
>
> > diff --git
> a/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag
> b/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag
> > index 1e03f27..ec832f9 100644
> > ---
> a/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag
> > +++
> b/tests/spec/glsl-1.20/compiler/storage-qualfiers/static-write-varying-01.frag
> > @@ -10,10 +10,6 @@
> >
> >  varying float x;
> >
> > -void f(out float y) {
> > -    y = 0.0;
> > -}
> > -
> >  void g() {
> > -    f(x);
> > +    y = 0.0;
> >  }
>
> This should be x = 0.0 too.
>
> Other than the little typos, this is
> Reviewec-by: Chad Versace <chad.versace at linux.intel.com>
> - ----
> Chad Versace
> chad.versace at linux.intel.com
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.11 (GNU/Linux)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iQIcBAEBAgAGBQJOvF/hAAoJEAIvNt057x8i+ekP+wauh7WPVERLOpL/W5dUNFXp
> 0hpKfRL5wa/K7h/YC6extOING0PLoWfh0CAlLC8N45oedbufN0p5Tu5q0eiNgmut
> +BqG5xL24qavM7Mt4EQ0Wg8s96D2j4qm94jq9iNVYAMYwxPmUaCvP9Gv33CEh/GN
> 1lko1xNActFCO68uFu/mUAP1Dp6DdjhFB4z8VjCOW/y2pv4lur2ma1HQkvK2hNDw
> jLI28oWwSX7ipHn/w0npX0D/ZeautLuK/pjMyDdIHuK74pW5tBGBJQgcWLGde4Ue
> TAvkGVQ9xs2970SLjLpQe4eDoHTSGDGUmh4C4tqANopvSyAUulKJhpMa+XA91tfm
> ihaKKpeXlARCI//bUDJV18AbgW6aRFCHLIKuqwoXzI0/sbZqoXAl6+WDK2LrCmRw
> CFTl8uoO1EAu07ARFLhSwWDgLiSAljNbXDktJeIFi8YSeAGVZdgG2TF2aGSaBW5e
> X8rRw+dvni9sz+de/ABLnWPPut3YPvoUCJ37aGbwejoq1v5xIaqPQlwnSbbH8M6D
> 05zjyO2ng/I2Z0esRgBVOb0GoDmSecM/N5wh9ZS1Nxh5UuUtmiqUhNoxElqFvxSz
> d+jyXdNuydvLzAA6dVMrNmGmnwI4v1JoihLxw3EqRWU3otnGmW/C5f1/xWmmKoV9
> h8G1mj3SJGp08qmD2vME
> =2E8L
> -----END PGP SIGNATURE-----
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/piglit/attachments/20111110/8fb72205/attachment.html>