[PATCH] plymouth/script: Fix window size with multiple heads

Ray Strode halfline at gmail.com
Tue Apr 16 05:49:41 PDT 2013


Charlie, what do you think about this patch?


On Mon, Apr 15, 2013 at 12:29 AM, Cristian Rodríguez <
crrodriguez at opensuse.org> wrote:

> From: Jeff Mahoney <jeffm at suse.com>
>
>  Plymouth "zooms" in on smaller displays when multiple displays are used,
>  but the script splash plugin defines the window size as the smallest
>  of the displays. When using a sprite as a background image, the wrong
>  size is used which leaves large chunks of the screen unused.
>
>  This patch uses the largest display as the window size, which allows
>  it to be appopriately cropped on smaller displays.
>
> Signed-off-by: Jeff Mahoney <jeffm at suse.com>
> Signed-off-by: Cristian Rodríguez <crrodriguez at opensuse.org>
> ---
>  src/plugins/splash/script/script-lib-sprite.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/plugins/splash/script/script-lib-sprite.c
> b/src/plugins/splash/script/script-lib-sprite.c
> index e0ced7e..c865cbb 100644
> --- a/src/plugins/splash/script/script-lib-sprite.c
> +++ b/src/plugins/splash/script/script-lib-sprite.c
> @@ -233,7 +233,7 @@ static script_return_t sprite_window_get_width
> (script_state_t *state,
>        if (width == 0)
>          width = ply_pixel_display_get_width (display->pixel_display);
>        else
> -        width = MIN (width, ply_pixel_display_get_width
> (display->pixel_display));
> +        width = MAX (width, ply_pixel_display_get_width
> (display->pixel_display));
>      }
>    return script_return_obj (script_obj_new_number (width));
>  }
> @@ -273,7 +273,7 @@ static script_return_t sprite_window_get_height
> (script_state_t *state,
>        if (height == 0)
>          height = ply_pixel_display_get_height (display->pixel_display);
>        else
> -        height = MIN (height, ply_pixel_display_get_height
> (display->pixel_display));
> +        height = MAX (height, ply_pixel_display_get_height
> (display->pixel_display));
>      }
>    return script_return_obj (script_obj_new_number (height));
>  }
> --
> 1.8.1.4
>
> _______________________________________________
> plymouth mailing list
> plymouth at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/plymouth
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/plymouth/attachments/20130416/033464e7/attachment.html>


More information about the plymouth mailing list