[Poppler-bugs] [Bug 40561] [PATCH] support for LinkMovie object in Qt4 frontend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=40561

--- Comment #2 from Albert Astals Cid <tsdgeos at terra.es> 2011-09-01 13:56:52 PDT ---
Some quick comments:
 * Please try to keep spacing consistant with the rest of the file, at least
the ifs are not correctly spaced
 * Please give all the parameters names
 * You pass r and g and then never use them, why?
 * All the data should be in the private, so please remove the protected
OperationType member and put it in the private

Thanks for the patch :-)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.