[Poppler-bugs] [Bug 40561] [PATCH] support for LinkMovie object in Qt4 frontend

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=40561

--- Comment #3 from edward.hades at gmail.com 2011-09-02 00:48:13 PDT ---
(In reply to comment #2)
> Some quick comments:
>  * Please try to keep spacing consistant with the rest of the file, at least
> the ifs are not correctly spaced

Have you noticed, you have at least two different styles across files? :)

>  * You pass r and g and then never use them, why?

An action can refer to a movie annotation either by title or by ref-gen pair.
I've done the title, but I've skipped the ref-gen comparison for now, since
MovieAnnotation does not store them (or at least I haven't found them). That's
why I called the support "partial".

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.