[pulseaudio-tickets] [Bug 105806] New: module-ladspa-sink: How can I use run_adding?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=105806

            Bug ID: 105806
           Summary: module-ladspa-sink: How can I use run_adding?
           Product: PulseAudio
           Version: unspecified
          Hardware: x86-64 (AMD64)
                OS: Linux (All)
            Status: NEW
          Severity: enhancement
          Priority: medium
         Component: modules
          Assignee: pulseaudio-bugs at lists.freedesktop.org
          Reporter: ovvv at web.de
        QA Contact: pulseaudio-bugs at lists.freedesktop.org
                CC: lennart at poettering.net

Created attachment 138417
  --> https://bugs.freedesktop.org/attachment.cgi?id=138417&action=edit
patch for run_adding

The run_adding function provided by some LADSPA plugins can be used to add the
plugin output scaled with a specified gain instead of using its output
directly.
So you can use it to specify the wet/dry level, can't you?

I've tried to implement it to module-ladspa-sink. The patch is in the
attachment.

When I tested it with the glame butterworth lowpass filter (butterworth_1902.so
from swh plugins), the debug message telling the configured gain appeared.
However, run_adding didn't work, I've set run_adding_gain to 0.1 and 10, the
output was the same both times, as though run instead of run_adding was used.
I've also tried setting the gain directly before run_adding is executed:
https://pastebin.com/mj3tBgaB
But it didn't change anything.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-bugs/attachments/20180329/3870ad2d/attachment.html>