[pulseaudio-discuss] [PATCH 2/3] coreaudio: Dynamically allocate C string when converting from CFString

[Mihai Moldovan]

On 04.01.2016 08:15 AM, arun at accosted.net wrote:
> From: Arun Raghavan <git at arunraghavan.net>
> 
> ---
>  src/modules/macosx/module-coreaudio-device.c | 60 +++++++++++++++-------------
>  1 file changed, 32 insertions(+), 28 deletions(-)
> 
> diff --git a/src/modules/macosx/module-coreaudio-device.c b/src/modules/macosx/module-coreaudio-device.c
> index 0c92d42..78edc6b 100644
> --- a/src/modules/macosx/module-coreaudio-device.c
> +++ b/src/modules/macosx/module-coreaudio-device.c
> @@ -550,25 +553,26 @@ static int ca_device_create_source(pa_module *m, AudioBuffer *buf, int channel_i
>  
>      for (i = 0; i < buf->mNumberChannels; i++) {
>          property_address.mSelector = kAudioObjectPropertyElementName;
> -        property_address.mScope = kAudioDevicePropertyScopeInput;
> +        property_address.mScope = kAudioDevicePropertyScopeOutput;

Uhm... what are you doing here? A source should be an input channel, right?


Everything else looks okay to me. Are you going to pick the patch? I have a few
changes that are dependent on this code, so I'd ask you to please pick it to
master and I'll base my patches on it.


Mihai

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20160211/644e6db0/attachment.sig>