[pulseaudio-discuss] [PATCH v3 01/24] echo-cancel: Update webrtc-audio-processing usage to new API

[Arun Raghavan]

On Sat, 2016-02-13 at 11:39 +0200, Tanu Kaskinen wrote:
> On Thu, 2016-02-11 at 19:49 +0100, Mihai Moldovan wrote:
> > On 22.01.2016 04:06 PM, Tanu Kaskinen wrote:
> > > On Mon, 2016-01-18 at 13:06 +0530, arun at accosted.net wrote:
> > > > From: Arun Raghavan <git at arunraghavan.net>
> > > > 
> > > > The code now needs C++11 support to compile with the updated
> > > > webrtc-audio-processing library.
> > > > ---
> > > >  configure.ac                      |  2 +-
> > > >  src/Makefile.am                   |  2 +-
> > > >  src/modules/echo-cancel/webrtc.cc | 54 +++++++++++++++++++++------------------
> > > >  3 files changed, 31 insertions(+), 27 deletions(-)
> > > 
> > > Looks good to me!
> > 
> > Actually... doesn't this deserve a check in configure if the compiler actually
> > supports C++11? If it doesn't, why make C++11 mandatory for everything? It
> > should only be used for the webrtc-audio-processing lib and otherwise leave
> > CXXFLAGS untouched (with webrtc-audio-processing being optional, as far as I've
> > seen.)
> 
> Ah, indeed, there should be a check in configure. Leaving CXXFLAGS
> untouched doesn't seem necessary, though. I don't think it makes sense
> to use different C++ standards for different parts of the code, so
> setting the standard globally to C++11 seems fine to me, unless there
> are some practical problems with that. (And since WebRTC is currently
> the only thing in PulseAudio using C++, I don't think it's possible to
> have practical problems.)

Yes, that's the only C++ code, so it's fine. I'll add the same AX macro
we have in pavucontrol for this.

-- Arun