[Spice-devel] [PATCH spice-server v2 1/8] spice.proto: s/Usbredir/Spicevmc

Alon Levy alevy at redhat.com
Tue Jan 10 05:27:28 PST 2012


On Tue, Jan 10, 2012 at 01:25:15PM +0200, Yonit Halperin wrote:

ACK series, great work on the protocol. Notice the last patch needs to
be fixed (0.10.1, not 0.10.0), the rest of my review is cosmetics / random comments.

> ---
>  spice.proto |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/spice.proto b/spice.proto
> index 266e03a..0ff1c12 100644
> --- a/spice.proto
> +++ b/spice.proto
> @@ -1112,7 +1112,7 @@ client:
>      Data data = 101;
>  };
>  
> -channel UsbredirChannel : BaseChannel {
> +channel SpicevmcChannel : BaseChannel {
>  server:
>      Data data = 101;
>  client:
> @@ -1128,5 +1128,5 @@ protocol Spice {
>      RecordChannel record;
>      TunnelChannel tunnel;
>      SmartcardChannel smartcard;
> -    UsbredirChannel usbredir;
> +    SpicevmcChannel spicevmc;
>  };
> -- 
> 1.7.6.4
> 


More information about the Spice-devel mailing list