[systemd-commits] src/journal

Zbigniew Jędrzejewski-Szmek zbyszek at kemper.freedesktop.org
Thu Jul 18 05:31:51 PDT 2013


 src/journal/journalctl.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a54e3b3d6a4fe28a39729f4c5ad11cd26706110c
Author: Zbigniew Jędrzejewski-Szmek <zbyszek at in.waw.pl>
Date:   Thu Jul 18 08:07:01 2013 -0400

    journalctl: fix signedness warning and boot-id syntax check

diff --git a/src/journal/journalctl.c b/src/journal/journalctl.c
index 9a40d69..2f043a4 100644
--- a/src/journal/journalctl.c
+++ b/src/journal/journalctl.c
@@ -744,7 +744,7 @@ static int get_relative_boot_id(sd_journal *j, sd_id128_t *boot_id, int relative
 
                 if (!id ||
                     relative <= 0 ? (id - all_ids) + relative < 0 :
-                                    (id - all_ids) + relative >= count)
+                                    (id - all_ids) + relative >= (int) count)
                         return -EADDRNOTAVAIL;
 
                 *boot_id = (id + relative)->id;
@@ -781,7 +781,7 @@ static int add_boot(sd_journal *j) {
 
                 offset = arg_boot_descriptor + 32;
 
-                if (*offset != '-' && *offset != '+') {
+                if (*offset && *offset != '-' && *offset != '+') {
                         log_error("Relative boot ID offset must start with a '+' or a '-', found '%s' ", offset);
                         return -EINVAL;
                 }



More information about the systemd-commits mailing list