[Bug 21594] New: Implement being a Handler

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=21594

           Summary: Implement being a Handler
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: telepathy-qt4
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: simon.mcvittie at collabora.co.uk


Andre has a branch. Some quick review comments:

* AbstractClientHandler::isListeningRequests() makes no sense grammatically and
neither does the constructor parameter listenRequests. wantsRequestNotification
would be better English

* Should the library be keeping track of the AbstractClientHandler's handled
channels, rather than requiring the Client to do it? (Add them when
HandleChannels accepts them, remove them when they close - to be
spec-compliant, it would need to take the union of the handled channels for
every Client that's sharing a unique name, see the spec for details)

* Didn't we agree that a newly created ChannelRequest should not be trying to
download its properties, at least in cases where the immutable properties
aren't supplied ahead of time? Most Observers won't care what the CR's
properties are, so they shouldn't have to make an extra round-trip for them

* When constructing unique names for Clients, note that (ulong) is not a safe
way to cast a pointer to a unique integer on LLP64 architectures like x86-64
Windows: perhaps cast it to intptr_t, which is a typedef for the integer type
of the same size as a pointer (e.g. long long on x86-64 Windows)

* It's 2009, please don't check in new code with © 2008

* How would you register the same Client name to be an observer, an approver
and a handler using this ClientRegistrar API? I don't see how you could...


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.