[Bug 21594] Implement being a Handler

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=21594





--- Comment #1 from Andre Moreira Magalhaes <andrunko at gmail.com>  2009-05-06 10:18:18 PST ---
(In reply to comment #0)
> Andre has a branch. Some quick review comments:
> 
> * AbstractClientHandler::isListeningRequests() makes no sense grammatically and
> neither does the constructor parameter listenRequests. wantsRequestNotification
> would be better English
Fixed

> * Didn't we agree that a newly created ChannelRequest should not be trying to
> download its properties, at least in cases where the immutable properties
> aren't supplied ahead of time? Most Observers won't care what the CR's
> properties are, so they shouldn't have to make an extra round-trip for them
> 
> * When constructing unique names for Clients, note that (ulong) is not a safe
> way to cast a pointer to a unique integer on LLP64 architectures like x86-64
> Windows: perhaps cast it to intptr_t, which is a typedef for the integer type
> of the same size as a pointer (e.g. long long on x86-64 Windows)
Fixed

> * It's 2009, please don't check in new code with © 2008
Fixed

> * How would you register the same Client name to be an observer, an approver
> and a handler using this ClientRegistrar API? I don't see how you could...
> 
Fixed. Clients should use ClientObject and set the observer, approver and
handler and then call ClientRegistrar::registerClient.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.