[Bug 21701] Tidy up caps parsing

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed May 13 14:34:19 CEST 2009


http://bugs.freedesktop.org/show_bug.cgi?id=21701





--- Comment #1 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk>  2009-05-13 05:34:19 PST ---
capabilities_parse: I guess you just copy/pasted the old function but maybe we
could change it to use tp_strdiff now.

set_caps_for: early return would be function clearer

I'm not sure about b5b629fdc8b79a33927dfd9c5de8d08e826df0e2
I guess that should be discussed.

08f75b635e3d328ecf148ca3286a56a4800972d2
The logic of the new code SEEMS ok to me but I can't assert for sure that's
exactly the same as the old code.

While looking at _caps_disco_cb I noticed that few lines are too long.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the telepathy-bugs mailing list