[Bug 21701] Tidy up caps parsing

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=21701





--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk>  2009-05-13 06:11:46 PST ---
(In reply to comment #1)
> capabilities_parse: I guess you just copy/pasted the old function but maybe we
> could change it to use tp_strdiff now.

      if (0 != strcmp (child->name, "feature"))

If Loudmouth gives us an LmMessageNode with a null name, we may already have
lost, surely?

          if (0 == strcmp (var, i->ns))

Both var and i->ns are known to be non-NULL.

> set_caps_for: early return would be function clearer

I'm not sure I agree that it makes it clearer but: 7d48d7e366c33b24a.

> I'm not sure about b5b629fdc8b79a33927dfd9c5de8d08e826df0e2
> I guess that should be discussed.

I agree. I added a FIXME as a reminder; this branch was meant to just be
refactoring and minor bugfixing, not changing behaviour.

> 08f75b635e3d328ecf148ca3286a56a4800972d2
> The logic of the new code SEEMS ok to me but I can't assert for sure that's
> exactly the same as the old code.

All the old tests pass. :-)

> While looking at _caps_disco_cb I noticed that few lines are too long.

Fixed in 053ed1ad246a; I added a similar function in 89c7ecfe9ea8.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.