[Bug 27463] improvements and clean ups

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27463

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review-, minor changes

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-05 08:19:37 PDT ---
> TplChannelText: show debug message only on non-empthy lists

Every Empathy developer's favourite typo. You mean empty :-)

> +  g_return_val_if_fail (!TPL_STR_EMPTY (chat_id), FALSE);

Not an objection, but if you depend on telepathy-glib (>= 0.11.0) you can use
the macro tp_str_empty() :-)

> +        "Unable to acknowledge pending message %d for chanenl %s: not found",

That's not how you spell channel.


>          }
> +      else
> +        PATH_DEBUG (proxy, "msg_id %d acknowledged", msg_id);

Consistent brace usage, please (the "if" clause has {}, so the "else" needs
them too)

Otherwise looks good.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.