[Bug 27463] improvements and clean ups

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27463

Cosimo Alfarano <cosimo.alfarano at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-, minor changes      |

--- Comment #2 from Cosimo Alfarano <cosimo.alfarano at collabora.co.uk> 2010-04-05 08:38:52 PDT ---
>> TplChannelText: show debug message only on non-empthy lists
>Every Empathy developer's favourite typo. You mean empty :-)

fixed :)

>> +        "Unable to acknowledge pending message %d for chanenl %s: not found",
>That's not how you spell channel.

fixed.


> Consistent brace usage, please (the "if" clause has {}, so the "else" needs
them too)

fixed.


> Not an objection, but if you depend on telepathy-glib (>= 0.11.0) you can use
the macro tp_str_empty() :-)

Yep, I saw the change, I'll update it using tp_str_empty in another path.

There are lots of pending branches around which need to be merged, after it
I'll start a cycle of general clean up of such things, before we'll declare the
stable API.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.