[Bug 29378] Implement Channel.Interface.Messages

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29378

Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://git.Collabora.co.uk/
                   |                            |?p=user/cassidy/telepathy-i
                   |                            |dle;a=shortlog;h=refs/heads
                   |                            |/messages-29378

--- Comment #1 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-08-17 01:39:22 PDT ---
I started implementing this in this branch:
http://git.Collabora.co.uk/?p=user/cassidy/telepathy-idle;a=shortlog;h=refs/heads/messages-29378

I'm neither an Idle or Messages expert so it may not be perfect.

I also have 2 questions:

- I didn't generate a message-token as Gabble does. Should I?

- messages/split-msg-sent-signal.py is broken. When splitting long messages
(because of protocol limitations), Idle used to fire the Sent signal for each
piece. Now I'm calling tp_message_mixin_sent() only once so this signal is
fired one time. I'm not sure it really makes sense to expose in Telepathy the
fact that messages are split. Furthermore, the mixin doesn't easily allow us to
call tp_message_mixin_sent() multi times as the TpMessage is created by tp-glib
and ownership is passed back to it once we call tp_message_mixin_sent() (so we
can't re-use it for the other pieces).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.