[Bug 29378] Implement Channel.Interface.Messages

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=29378

--- Comment #2 from Olli Salli <ollisal at gmail.com> 2010-08-31 02:32:43 PDT ---
Yeah, emitting Sent just once is what you should do IMO - the original message
splitting impl was just a real quick hack IIRC and I didn't properly consider
this it seems :) Another issue is Sent should only be emitted when the last
part of the message is actually cleared from the server connection send queue
in IdleConnection (not when it's only queued there), so there should be some
kind of callback mechanism for dequeued messages - or was there already, I
can't recall...

As for the message token, at least tp-qt4 explicitly doesn't require one to be
present. You should generate one if you can in any way produce an unique id for
the message, though - which might be a bit hard on IRC as there are no running
serials or message ids or anything. What does gabble do, hash something? What
does it hash exactly?

I'll probably take a look at the other parts sometime soon but I can't
guarantee anything as I'm frankly quite busy at the moment.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.