[Bug 28469] [PATCH] add support for PurpleAccountUserSplit

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28469

--- Comment #3 from Stefan Becker <stefan.becker at nokia.com> 2010-06-10 05:58:20 PDT ---
Thanks, I cloned the git and your rebase seems to work in my quick test.

BTW: this is not a SIPE only issue. A quick scan through Pidgin protocol plugin
source code reveals:

bonjour/bonjour.c:      PurpleAccountUserSplit *split;
irc/irc.c:      PurpleAccountUserSplit *split;
jabber/libxmpp.c:       PurpleAccountUserSplit *split;
null/nullprpl.c:  PurpleAccountUserSplit *split =
purple_account_user_split_new(
silc10/silc.c:  PurpleAccountUserSplit *split;
silc/silc.c:    PurpleAccountUserSplit *split;
simple/simple.c:        PurpleAccountUserSplit *split;

So these changes might help those protocols too...


I realized that making them mandatory parameters is not correct, i.e. it will
not work for users that need to leave one of the parameters empty. I'll submit
another patch based on your re-base once I'm done.


As for the style: have you considered adding at least some hints for Emacs to
end of each file? Then the Emacs C mode will make sure that the code is entered
using the correct style. Here is the settings we use for pidgin-sipe code:

/*
  Local Variables:
  mode: c
  c-file-style: "bsd"
  indent-tabs-mode: t
  tab-width: 8
  End:
*/

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.