[Bug 28469] [PATCH] add support for PurpleAccountUserSplit

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28469

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2010-06-10 06:06:10 PDT ---
(In reply to comment #3)
> Thanks, I cloned the git and your rebase seems to work in my quick test.

Great!

> BTW: this is not a SIPE only issue. A quick scan through Pidgin protocol plugin
> source code reveals:
> 
> bonjour/bonjour.c:      PurpleAccountUserSplit *split;
> irc/irc.c:      PurpleAccountUserSplit *split;
> jabber/libxmpp.c:       PurpleAccountUserSplit *split;
> null/nullprpl.c:  PurpleAccountUserSplit *split =
> purple_account_user_split_new(
> silc10/silc.c:  PurpleAccountUserSplit *split;
> silc/silc.c:    PurpleAccountUserSplit *split;
> simple/simple.c:        PurpleAccountUserSplit *split;
> 
> So these changes might help those protocols too...

Yeah, that's true. (That said... I don't really expect anyone to use the first
three through Haze (we have native CMs for Bonjour, IRC and Jabber, which work
better), although IRC is bug 14213 and Jabber is bug 14212, and I had a quick
stab at making them work with Jabber yesterday. Simple: well, we have a SIP CM.
And does anyone use SILC? ☺)

> I realized that making them mandatory parameters is not correct, i.e. it will
> not work for users that need to leave one of the parameters empty. I'll submit
> another patch based on your re-base once I'm done.

Great, thanks.

> As for the style: have you considered adding at least some hints for Emacs to
> end of each file? Then the Emacs C mode will make sure that the code is entered
> using the correct style.

Yep, that's a good idea. I think the modelines for emacs and Vim should follow
<http://telepathy.freedesktop.org/wiki/Style>, since that's the direction I'd
like Haze to head.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.