[Bug 26205] High-level API for ContactLists

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26205

--- Comment #45 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-08-04 04:15:31 PDT ---
Review of attachment 49904:
 --> (https://bugs.freedesktop.org/review?bug=26205&attachment=49904)

::: telepathy-glib/util.c
@@ +1923,3 @@
+
+GPtrArray *
+_tp_contacts_from_values (GHashTable *table)

I'd add a comment explaining the kind of hash table expected.

@@ +1934,3 @@
+  g_hash_table_iter_init (&iter, table);
+  while (g_hash_table_iter_next (&iter, NULL, &value))
+  gpointer value;

Add an assertion/check ensuring that's a TpContact ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.