[Bug 26205] High-level API for ContactLists

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26205

--- Comment #46 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-08-04 04:38:06 PDT ---
Review of attachment 49905:
 --> (https://bugs.freedesktop.org/review?bug=26205&attachment=49905)

::: telepathy-glib/connection-contact-list.c
@@ +94,3 @@
+
+      contact = g_hash_table_lookup (self->priv->roster, key);
+  tp_clear_pointer (&item->identifiers, g_hash_table_unref);

How can contact be NULL? CM bug? Maybe it's worth displaying a debug in this
case.

@@ +101,3 @@
+    }
+
+}

This comment is bit miss leading as you didn't filter out any contact at this
stage (you already removed contacts which was already in the roster in
process_queued_contacts_changed).

@@ +278,3 @@
+  const gchar **supported_interfaces;
+
+      TpContact *contact = g_hash_table_lookup (self->priv->roster, key);

display the path of the connection

@@ +697,3 @@
+ * @self: a #TpConnection
+ *
+ * The list of contacts associated with the user, but MAY contain other

the doc should mention @self somewhere. "associated with the user on @self"?

@@ +700,3 @@
+ * contacts. This list does not contain every visible contact: for instance,
+ * contacts seen in XMPP or IRC chatrooms does not appear here. Blocked
contacts
+ * does not appear here, unless they still have a non-No subscribe or publish

This isn't very clear. Can't we express that in term of TpContact flags or
something?

@@ +709,3 @@
+ * For this method to be valid, you must first call tp_proxy_prepare_async()
+ * with the feature %TP_CONNECTION_FEATURE_CONTACT_LIST and verify the
+ * does not appear here, unless they still have a non-No subscribe or publish

Does that mean that having the feature prepared is not enough to safely call
this function?

::: telepathy-glib/connection.c
@@ +2071,3 @@
       _tp_marshal_VOID__STRING_STRING,
       G_TYPE_NONE, 2, G_TYPE_STRING, G_TYPE_STRING);
+  /**

missing \n

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.