[Bug 26205] High-level API for ContactLists

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Aug 4 14:27:05 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=26205

--- Comment #53 from Xavier Claessens <xclaesse at gmail.com> 2011-08-04 05:27:02 PDT ---
(In reply to comment #45)
> Review of attachment 49904 [details]:
> 
> ::: telepathy-glib/util.c
> @@ +1923,3 @@
> +
> +GPtrArray *
> +_tp_contacts_from_values (GHashTable *table)
> 
> I'd add a comment explaining the kind of hash table expected.
> 
> @@ +1934,3 @@
> +  g_hash_table_iter_init (&iter, table);
> +  while (g_hash_table_iter_next (&iter, NULL, &value))
> +  gpointer value;
> 
> Add an assertion/check ensuring that's a TpContact ?

fixed and picked to master

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list