[Bug 26205] High-level API for ContactLists

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26205

--- Comment #54 from Xavier Claessens <xclaesse at gmail.com> 2011-08-04 06:39:51 PDT ---
Review of attachment 49905:
 --> (https://bugs.freedesktop.org/review?bug=26205&attachment=49905)

::: telepathy-glib/connection-contact-list.c
@@ +94,3 @@
+
+      contact = g_hash_table_lookup (self->priv->roster, key);
+      if (contact != NULL)

right, broken CM. Added a DEBUG().

@@ +101,3 @@
+    }
+
+  /* Add contacts to roster and build a list of contacts really added */

right, removed the "really" since we add it even if it already exists, which is
fine tbh :)

@@ +278,3 @@
+  const gchar **supported_interfaces;
+
+  DEBUG ("CM has the roster, fetch it now");

done

@@ +700,3 @@
+ * contacts. This list does not contain every visible contact: for instance,
+ * contacts seen in XMPP or IRC chatrooms does not appear here. Blocked
contacts
+ * does not appear here, unless they still have a non-No subscribe or publish

this is copy/paste from spec tbh. Blocked is not yet defined on TpContact, but
the "have a non-No subscribe or publish" can be expressed as TpContact
properties, indeed.

@@ +709,3 @@
+ * For this method to be valid, you must first call tp_proxy_prepare_async()
+ * with the feature %TP_CONNECTION_FEATURE_CONTACT_LIST and verify the
+ * #TpConnection:contact-list-state is set to %TP_CONTACT_LIST_STATE_SUCCESS.

if state is not SUCCESS, even if feature is prepared, returned list will be
empty. Feature being prepared means "we know CM's state" but does not mean the
CM already fetched from server. Doc could be improved I guess...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.