[Bug 26205] High-level API for ContactLists

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=26205

--- Comment #55 from Xavier Claessens <xclaesse at gmail.com> 2011-08-04 06:59:39 PDT ---
Review of attachment 49906:
 --> (https://bugs.freedesktop.org/review?bug=26205&attachment=49906)

::: examples/client/contact-list.c
@@ +71,3 @@
+      0 };
+  const GQuark connection_features[] = {
+      TP_CONNECTION_FEATURE_CONTACT_LIST,

hm, the automatic factory is the one used by default, this means by default it
would prepare the contact-list unless explicitly asking for a
TpSimpleClientFactory.

atm the automatic only ask for CORE features... IMO it's cheap enough to list
features when creating the factory. it's just that CORE is required for the
proxy to be useful at all.

no?

::: examples/client/python/contact-list.py
@@ +11,3 @@
+
+    accounts = manager.get_valid_accounts()
+    for account in accounts:

done

@@ +13,3 @@
+    for account in accounts:
+        connection = account.get_connection()
+        if connection != None:

done

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.