[Bug 39933] Gabble advertises tube services as supported with just a Chan.Requested=true Client filter

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Wed Aug 10 17:54:45 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=39933

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-08-10 08:54:45 PDT ---
> + if (tp_asv_get_boolean (cap, TP_IFACE_CHANNEL ".Requested", FALSE) == TRUE)

Ideally TP_PROP_CHANNEL_REQUESTED or whatever we called it. I'd prefer without
the "== TRUE".

Could we have a regression test for a channel class that doesn't mention
Requested (= matches both incoming and outgoing), just to be sure? I think your
implementation will get that right too, though.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list