[Bug 39933] Gabble advertises tube services as supported with just a Chan.Requested=true Client filter

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39933

--- Comment #4 from Olli Salli <ollisal at gmail.com> 2011-08-10 09:24:13 PDT ---
(In reply to comment #3)
> > + if (tp_asv_get_boolean (cap, TP_IFACE_CHANNEL ".Requested", FALSE) == TRUE)
> 
> Ideally TP_PROP_CHANNEL_REQUESTED or whatever we called it. I'd prefer without

Ok, ported the whole file to TP_PROP constants for consistency.

> the "== TRUE".

Done

> 
> Could we have a regression test for a channel class that doesn't mention
> Requested (= matches both incoming and outgoing), just to be sure? I think your
> implementation will get that right too, though.

We do now, and it did get it right.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.