[Bug 39933] Gabble advertises tube services as supported with just a Chan.Requested=true Client filter

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39933

Olli Salli <ollisal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Olli Salli <ollisal at gmail.com> 2011-08-10 11:42:01 PDT ---
(In reply to comment #5)
> Looks good to me.
> 

Ok thanks, will merge.

> (In reply to comment #0)
> > for stream tubes
> > this is especially important, as the initiator (classically, a TCP server) and
> > receiver (~TCP client) applications are often separate and not dependent on
> > each other
> 
> In recent MC, you only need to add a { Requested = TRUE } filter if you want to
> be eligible to handle channels requested by others. If you are the
> PreferredHandler (as you ought to be for channels you request yourself), you
> will receive the channel anyway, and being a Handler with a zero-length list of
> filters (i.e. match nothing) is often the right thing...
> 
> (Note that there's a difference between HandlerChannelFilters = [], which
> matches nothing, and HandlerChannelFilters = [{}], which matches everything.)

Sure. In TpQt4 we have the {create,ensure}AndHandle* APIs which work in exactly
this fashion (create a behind-the-scenes Handler with an empty filter and a
random name, pass it as the PreferredHandler). However, many interesting use
cases (in KDE telepathy mainly) have the channels requested from an another
application, most often the contact list. We've had some ideas to enable
starting arbitrary kinds of sessions from the contact list, including tubes.

> 
> > after all, as Will pointed out, on some protocols it might be perfectly
> > sensible to advertise to the network e.g. that "this person here might call
> > you" ( there is a Handler with a Requested=true, Type=Call class in its
> > filters)
> 
> ... although that usage would break the ability to do this.

Yeah. Perhaps we should try and see whether there are protocols which actually
support that, and try and make the spec steer people towards registering the
Requested=true handlers anyway, if so.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.