[Bug 39933] Gabble advertises tube services as supported with just a Chan.Requested=true Client filter

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39933

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #5 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-08-10 09:43:51 PDT ---
Looks good to me.

(In reply to comment #0)
> for stream tubes
> this is especially important, as the initiator (classically, a TCP server) and
> receiver (~TCP client) applications are often separate and not dependent on
> each other

In recent MC, you only need to add a { Requested = TRUE } filter if you want to
be eligible to handle channels requested by others. If you are the
PreferredHandler (as you ought to be for channels you request yourself), you
will receive the channel anyway, and being a Handler with a zero-length list of
filters (i.e. match nothing) is often the right thing...

(Note that there's a difference between HandlerChannelFilters = [], which
matches nothing, and HandlerChannelFilters = [{}], which matches everything.)

> after all, as Will pointed out, on some protocols it might be perfectly
> sensible to advertise to the network e.g. that "this person here might call
> you" ( there is a Handler with a Requested=true, Type=Call class in its
> filters)

... although that usage would break the ability to do this.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.