[Bug 34316] UpdateParameters: bad handling of DBus_Property and Has_Default in Unset argument

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Feb 18 18:33:11 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=34316

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|                            |http://git.collabora.co.uk/
                   |                            |?p=user/wjt/telepathy-missi
                   |                            |on-control-wjt.git;a=shortl
                   |                            |og;h=refs/heads/fd.o-34316-
                   |                            |UpdateParameters-fixes
           Keywords|                            |patch

--- Comment #5 from Will Thompson <will.thompson at collabora.co.uk> 2011-02-18 09:33:10 PST ---
Here's a (remarkably large) branch which cleans up the UpdateParameters()
implementation and fixes this bug (as well as a couple of related bugs and a
leak I spotted along the way).

% git diff --stat master src
 src/mcd-account-manager.c |    6 -
 src/mcd-account.c         |  358 ++++++++++++++++++++-------------------------
 src/mcd-account.h         |    7 +-
 3 files changed, 164 insertions(+), 207 deletions(-)
% git diff --stat master tests
 tests/twisted/account-manager/update-parameters.py |   97 +++++++++++++++++---
 tests/twisted/telepathy/managers/fakecm.manager    |    4 +-
 2 files changed, 87 insertions(+), 14 deletions(-)

I'll fix up the spec on Monday.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list